Skip to content

Commit

Permalink
test(passive-events): Passive event listener violation doesn't report…
Browse files Browse the repository at this point in the history
… on passive:false now
  • Loading branch information
paulirish committed Oct 6, 2017
1 parent bedb9a1 commit d8015b7
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 2 deletions.
2 changes: 1 addition & 1 deletion lighthouse-cli/test/fixtures/dobetterweb/dbw_tester.html
Expand Up @@ -209,7 +209,7 @@ <h2>Do better web tester page</h2>
console.log('touchstart');
});

// FAIL
// PASS - passive:false doesn't get a warning now. crbug.com/770208
window.addEventListener('mousewheel', function(e) {
console.log('mousewheel');
}, {passive: false});
Expand Down
Expand Up @@ -158,7 +158,8 @@ module.exports = [
value: {
// Note: This would normally be 7 but M56 defaults document-level
// listeners to passive. See https://www.chromestatus.com/features/5093566007214080
length: 4,
// Note: Explicitly passive:false doesn't get a warning as of M63: crbug.com/770208
length: '>=3',
},
},
},
Expand Down

0 comments on commit d8015b7

Please sign in to comment.