perf: consolidate DBW pass into defaultPass (#2160)

lighthouse-cli/test/fixtures/dobetterweb/dbw_tester.html

@@ -39,6 +39,8 @@
 
 <!-- PASS: preload that's activated later does not block rendering. -->
 <link rel="preload" href="./dbw_tester.css?delay=2000&async=true" as="style" onload="this.rel = 'stylesheet'">
+<!-- PASS: async stylesheet that loads after FCP -->
+<link rel="stylesheet" href="./dbw_tester.css?delay=3000&async=true" disabled onload="this.disabled = false">
 
 <!-- FAIL: block rendering -->
 <script src="./dbw_tester.js"></script>

lighthouse-cli/test/smokehouse/dobetterweb/dbw-expectations.js

@@ -32,7 +32,7 @@ module.exports = [
         extendedInfo: {
           value: {
             results: {
-              length: 13
+              length: 14
             }
           }
         }
@@ -64,26 +64,6 @@ module.exports = [
           }
         }
       },
-      'no-console-time': {
-        score: false,
-        extendedInfo: {
-          value: {
-            results: {
-              length: 3
-            }
-          }
-        }
-      },
-      'no-datenow': {
-        score: false,
-        extendedInfo: {
-          value: {
-            results: {
-              length: 5
-            }
-          }
-        }
-      },
       'no-document-write': {
         score: false,
         extendedInfo: {
@@ -135,9 +115,7 @@ module.exports = [
           value: {
             // Note: This would normally be 7 but M56 defaults document-level
             // listeners to passive. See https://www.chromestatus.com/features/5093566007214080
-            results: {
-              length: 4
-            }
+            length: 4
           }
         }
       },
@@ -232,12 +210,6 @@ module.exports = [
       'link-blocking-first-paint': {
         score: 100
       },
-      'no-console-time': {
-        score: true
-      },
-      'no-datenow': {
-        score: true
-      },
       'no-document-write': {
         score: true
       },

lighthouse-core/audits/dobetterweb/geolocation-on-start.js

@@ -22,10 +22,10 @@
 
 'use strict';
 
-const Audit = require('../audit');
+const ViolationAudit = require('../violation-audit');
 const Formatter = require('../../report/formatter');
 
-class GeolocationOnStart extends Audit {
+class GeolocationOnStart extends ViolationAudit {
   /**
    * @return {!AuditMeta}
    */
@@ -37,7 +37,7 @@ class GeolocationOnStart extends Audit {
       helpText: 'Users are mistrustful of or confused by sites that request their ' +
           'location without context. Consider tying the request to user gestures instead. ' +
           '[Learn more](https://developers.google.com/web/tools/lighthouse/audits/geolocation-on-load).',
-      requiredArtifacts: ['GeolocationOnStart']
+      requiredArtifacts: ['ChromeConsoleMessages']
     };
   }
 
@@ -46,18 +46,13 @@ class GeolocationOnStart extends Audit {
    * @return {!AuditResult}
    */
   static audit(artifacts) {
-    const results = artifacts.GeolocationOnStart.map(err => {
-      return Object.assign({
-        label: `line: ${err.line}, col: ${err.col}`
-      }, err);
-    });
-
+    const results = ViolationAudit.getViolationResults(artifacts, /geolocation/);
 
     const headings = [
       {key: 'url', itemType: 'url', text: 'URL'},
       {key: 'label', itemType: 'text', text: 'Location'},
     ];
-    const details = Audit.makeV2TableDetails(headings, results);
+    const details = ViolationAudit.makeV2TableDetails(headings, results);
 
     return {
       rawValue: results.length === 0,

lighthouse-core/audits/dobetterweb/link-blocking-first-paint.js

@@ -46,23 +46,27 @@ class LinkBlockingFirstPaintAudit extends Audit {
       helpText: 'Link elements are blocking the first paint of your page. Consider ' +
           'inlining critical links and deferring non-critical ones. ' +
           '[Learn more](https://developers.google.com/web/tools/lighthouse/audits/blocking-resources).',
-      requiredArtifacts: ['TagsBlockingFirstPaint']
+      requiredArtifacts: ['TagsBlockingFirstPaint', 'traces']
     };
   }
 
   /**
    * @param {!Artifacts} artifacts
    * @param {string} tagFilter The tagName to filter on
-   * @param {number=} loadThreshold Filter to resources that took at least this
+   * @param {number=} endTimeMax The trace milisecond timestamp that offending tags must have ended
+   *    before (typically first contentful paint).
+   * @param {number=} loadDurationThreshold Filter to resources that took at least this
    *    many milliseconds to load.
    * @return {!AuditResult} The object to pass to `generateAuditResult`
    */
-  static computeAuditResultForTags(artifacts, tagFilter, loadThreshold = 0) {
+  static computeAuditResultForTags(artifacts, tagFilter, endTimeMax = Infinity,
+      loadDurationThreshold = 0) {
     const artifact = artifacts.TagsBlockingFirstPaint;
 
     const filtered = artifact.filter(item => {
       return item.tag.tagName === tagFilter &&
-        (item.endTime - item.startTime) * 1000 >= loadThreshold;
+        (item.endTime - item.startTime) * 1000 >= loadDurationThreshold &&
+        item.endTime * 1000 < endTimeMax;
     });
 
     const startTime = filtered.length === 0 ? 0 :
@@ -117,7 +121,11 @@ class LinkBlockingFirstPaintAudit extends Audit {
    * @return {!AuditResult}
    */
   static audit(artifacts) {
-    return this.computeAuditResultForTags(artifacts, 'LINK', LOAD_THRESHOLD_IN_MS);
+    const trace = artifacts.traces[Audit.DEFAULT_PASS];
+    return artifacts.requestTraceOfTab(trace).then(traceOfTab => {
+      const fcp = traceOfTab.timestamps.firstContentfulPaint;
+      return this.computeAuditResultForTags(artifacts, 'LINK', fcp, LOAD_THRESHOLD_IN_MS);
+    });
   }
 }
 

lighthouse-core/audits/dobetterweb/no-document-write.js

@@ -21,10 +21,10 @@
 
 'use strict';
 
-const Audit = require('../audit');
+const ViolationAudit = require('../violation-audit');
 const Formatter = require('../../report/formatter');
 
-class NoDocWriteAudit extends Audit {
+class NoDocWriteAudit extends ViolationAudit {
 
   /**
    * @return {!AuditMeta}
@@ -37,7 +37,7 @@ class NoDocWriteAudit extends Audit {
       helpText: 'For users on slow connections, external scripts dynamically injected via ' +
           '`document.write()` can delay page load by tens of seconds. ' +
           '[Learn more](https://developers.google.com/web/tools/lighthouse/audits/document-write).',
-      requiredArtifacts: ['DocWriteUse']
+      requiredArtifacts: ['ChromeConsoleMessages']
     };
   }
 
@@ -46,17 +46,13 @@ class NoDocWriteAudit extends Audit {
    * @return {!AuditResult}
    */
   static audit(artifacts) {
-    const results = artifacts.DocWriteUse.map(err => {
-      return Object.assign({
-        label: `line: ${err.line}, col: ${err.col}`
-      }, err);
-    });
+    const results = ViolationAudit.getViolationResults(artifacts, /document\.write/);
 
     const headings = [
       {key: 'url', itemType: 'url', text: 'URL'},
       {key: 'label', itemType: 'text', text: 'Location'},
     ];
-    const details = Audit.makeV2TableDetails(headings, results);
+    const details = ViolationAudit.makeV2TableDetails(headings, results);
 
     return {
       rawValue: results.length === 0,

lighthouse-core/audits/dobetterweb/no-mutation-events.js

@@ -69,7 +69,7 @@ class NoMutationEventsAudit extends Audit {
       const isMutationEvent = this.MUTATION_EVENTS.includes(loc.type);
       let sameHost = URL.hostsMatch(artifacts.URL.finalUrl, loc.url);
 
-      if (!URL.isValid(loc.url)) {
+      if (!URL.isValid(loc.url) && isMutationEvent) {
         sameHost = true;
         debugString = URL.INVALID_URL_DEBUG_STRING;
       }