feedback

GoogleChrome · Mar 28, 2017 · dedb994 · dedb994
1 parent f53654e
commit dedb994
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/lighthouse-core/audits/works-offline.js b/lighthouse-core/audits/works-offline.js
@@ -16,6 +16,7 @@
  */
 'use strict';
 
+const URL = require('../lib/url-shim');
 const Audit = require('./audit');
 
 class WorksOffline extends Audit {
@@ -40,9 +41,9 @@ class WorksOffline extends Audit {
    */
   static audit(artifacts) {
     let debugString;
-    if (artifacts.URL.initialUrl !== artifacts.URL.finalUrl) {
+    if (!URL.equalWithExcludedFragments(artifacts.URL.initialUrl, artifacts.URL.finalUrl)) {
       debugString = 'WARNING: You may be failing this check because your test URL ' +
-          `(${artifacts.URL.initialUrl}) was redirected to ${artifacts.URL.finalUrl}. ` +
+          `(${artifacts.URL.initialUrl}) was redirected to "${artifacts.URL.finalUrl}". ` +
           'Try testing the second URL directly.';
     }
 

diff --git a/lighthouse-core/test/audits/works-offline-test.js b/lighthouse-core/test/audits/works-offline-test.js
@@ -36,7 +36,7 @@ describe('Offline: works-offline audit', () => {
   it('warns if initial url does not match final url', () => {
     const output = Audit.audit({
       Offline: 200,
-      URL: {initialUrl: URL, finalUrl: '${URL}/features'}
+      URL: {initialUrl: URL, finalUrl: `${URL}/features`}
     });
 
     assert.equal(output.rawValue, true);