Merge pull request #1579 from GoogleChrome/chrome_stable_img_opt

fix(optimized-images): dedupe image URLs
GoogleChrome · Jan 30, 2017 · e4196de · e4196de
2 parents 99a4638 + 6a6c62a
commit e4196de
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 0 deletions.
diff --git a/lighthouse-core/gather/gatherers/dobetterweb/optimized-images.js b/lighthouse-core/gather/gatherers/dobetterweb/optimized-images.js
@@ -71,7 +71,13 @@ class OptimizedImages extends Gatherer {
    * @return {!Array<{url: string, isBase64DataUri: boolean, mimeType: string, resourceSize: number}>}
    */
   static filterImageRequests(pageUrl, networkRecords) {
+    const seenUrls = new Set();
     return networkRecords.reduce((prev, record) => {
+      if (seenUrls.has(record._url)) {
+        return prev;
+      }
+
+      seenUrls.add(record._url);
       const isOptimizableImage = /image\/(png|bmp|jpeg)/.test(record._mimeType);
       const isSameOrigin = URL.hostsMatch(pageUrl, record._url);
       const isBase64DataUri = /^data:.{2,40}base64\s*,/.test(record._url);

diff --git a/lighthouse-core/test/gather/gatherers/dobetterweb/optimized-images-test.js b/lighthouse-core/test/gather/gatherers/dobetterweb/optimized-images-test.js
@@ -44,6 +44,11 @@ const traceData = {
       _mimeType: 'image/bmp',
       _resourceSize: 12,
     },
+    {
+      _url: 'http://google.com/image.bmp',
+      _mimeType: 'image/bmp',
+      _resourceSize: 12,
+    },
     {
       _url: 'http://google.com/vector.svg',
       _mimeType: 'image/svg+xml',