-
Notifications
You must be signed in to change notification settings - Fork 9.3k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Inject Lighthouse metrics back into trace for viewing (#1446)
- Loading branch information
1 parent
a067d30
commit ee8d967
Showing
6 changed files
with
66,136 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,206 @@ | ||
/** | ||
* @license | ||
* Copyright 2017 Google Inc. All rights reserved. | ||
* | ||
* Licensed under the Apache License, Version 2.0 (the "License"); | ||
* you may not use this file except in compliance with the License. | ||
* You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
*/ | ||
'use strict'; | ||
|
||
const log = require('../../../lighthouse-core/lib/log.js'); | ||
|
||
class Metrics { | ||
|
||
constructor(traceEvents, auditResults) { | ||
this._traceEvents = traceEvents; | ||
this._auditResults = auditResults; | ||
} | ||
|
||
/** | ||
* Returns simplified representation of all metrics | ||
* @return {!Array<{getTs: Function, id: string, name: string}>} metrics to consider | ||
*/ | ||
static get metricsDefinitions() { | ||
return [ | ||
{ | ||
name: 'Navigation Start', | ||
id: 'navstart', | ||
getTs: auditResults => { | ||
const fmpExt = auditResults['first-meaningful-paint'].extendedInfo; | ||
return fmpExt.value.timestamps.navStart; | ||
} | ||
}, | ||
{ | ||
name: 'First Contentful Paint', | ||
id: 'ttfcp', | ||
getTs: auditResults => { | ||
const fmpExt = auditResults['first-meaningful-paint'].extendedInfo; | ||
return fmpExt.value.timestamps.fCP; | ||
} | ||
}, | ||
{ | ||
name: 'First Meaningful Paint', | ||
id: 'ttfmp', | ||
getTs: auditResults => { | ||
const fmpExt = auditResults['first-meaningful-paint'].extendedInfo; | ||
return fmpExt.value.timestamps.fMP; | ||
} | ||
}, | ||
{ | ||
name: 'Perceptual Speed Index', | ||
id: 'psi', | ||
getTs: auditResults => { | ||
const siExt = auditResults['speed-index-metric'].extendedInfo; | ||
return siExt.value.timestamps.perceptualSpeedIndex; | ||
} | ||
}, | ||
{ | ||
name: 'First Visual Change', | ||
id: 'fv', | ||
getTs: auditResults => { | ||
const siExt = auditResults['speed-index-metric'].extendedInfo; | ||
return siExt.value.timestamps.firstVisualChange; | ||
} | ||
}, | ||
{ | ||
name: 'Visually Complete 85%', | ||
id: 'vc85', | ||
getTs: auditResults => { | ||
const siExt = auditResults['time-to-interactive'].extendedInfo; | ||
return siExt.value.timestamps.visuallyReady; | ||
} | ||
}, | ||
{ | ||
name: 'Visually Complete 100%', | ||
id: 'vc100', | ||
getTs: auditResults => { | ||
const siExt = auditResults['speed-index-metric'].extendedInfo; | ||
return siExt.value.timestamps.visuallyComplete; | ||
} | ||
}, | ||
{ | ||
name: 'Time to Interactive', | ||
id: 'tti', | ||
getTs: auditResults => { | ||
const ttiExt = auditResults['time-to-interactive'].extendedInfo; | ||
return ttiExt.value.timestamps.timeToInteractive; | ||
} | ||
} | ||
]; | ||
} | ||
|
||
/** | ||
* Returns simplified representation of all metrics' timestamps from monotonic clock | ||
* @return {!Array<{ts: number, id: string, name: string}>} metrics to consider | ||
*/ | ||
gatherMetrics() { | ||
const metricDfns = Metrics.metricsDefinitions; | ||
const resolvedMetrics = []; | ||
metricDfns.forEach(metric => { | ||
// try/catch in case auditResults is missing a particular audit result | ||
try { | ||
resolvedMetrics.push({ | ||
id: metric.id, | ||
name: metric.name, | ||
ts: metric.getTs(this._auditResults) | ||
}); | ||
} catch (e) { | ||
log.error('pwmetrics-events', `${metric.name} timestamp not found: ${e.message}`); | ||
} | ||
}); | ||
return resolvedMetrics; | ||
} | ||
|
||
/** | ||
* Getter for our navigationStart trace event | ||
*/ | ||
getNavigationStartEvt() { | ||
if (!this._navigationStartEvt) { | ||
const filteredEvents = this._traceEvents.filter(e => { | ||
return e.name === 'TracingStartedInPage' || e.cat === 'blink.user_timing'; | ||
}); | ||
|
||
const tracingStartedEvt = filteredEvents.filter(e => e.name === 'TracingStartedInPage')[0]; | ||
const navigationStartEvt = filteredEvents.filter(e => { | ||
return e.name === 'navigationStart' && | ||
e.pid === tracingStartedEvt.pid && e.tid === tracingStartedEvt.tid; | ||
})[0]; | ||
this._navigationStartEvt = navigationStartEvt; | ||
} | ||
return this._navigationStartEvt; | ||
} | ||
|
||
|
||
/** | ||
* Constructs performance.measure trace events, which have start/end events as follows: | ||
* { "pid": 89922,"tid":1295,"ts":77176783452,"ph":"b","cat":"blink.user_timing","name":"innermeasure","args":{},"tts":1257886,"id":"0xe66c67"} | ||
* { "pid": 89922,"tid":1295,"ts":77176882592,"ph":"e","cat":"blink.user_timing","name":"innermeasure","args":{},"tts":1257898,"id":"0xe66c67"} | ||
* @param {{ts: number, id: string, name: string}} metric | ||
* @param {number} navStartTs | ||
* @return {!Array} Pair of trace events (start/end) | ||
*/ | ||
synthesizeEventPair(metric, navStartTs) { | ||
// We'll masquerade our fake events to look mostly like navigationStart | ||
const eventBase = { | ||
pid: this.getNavigationStartEvt().pid, | ||
tid: this.getNavigationStartEvt().tid, | ||
cat: 'blink.user_timing', | ||
name: metric.name, | ||
args: {}, | ||
// randomized id is same for the pair | ||
id: `0x${((Math.random() * 1000000) | 0).toString(16)}` | ||
}; | ||
const fakeMeasureStartEvent = Object.assign({}, eventBase, { | ||
ts: navStartTs, | ||
ph: 'b' | ||
}); | ||
const fakeMeasureEndEvent = Object.assign({}, eventBase, { | ||
ts: metric.ts, | ||
ph: 'e', | ||
}); | ||
return [fakeMeasureStartEvent, fakeMeasureEndEvent]; | ||
} | ||
|
||
/** | ||
* @returns {!Array} User timing raw trace event pairs | ||
*/ | ||
generateFakeEvents() { | ||
const fakeEvents = []; | ||
const metrics = this.gatherMetrics(); | ||
if (metrics.length === 0) { | ||
log.error('metrics-events', 'Metrics collection had errors, not synthetizing trace events'); | ||
return []; | ||
} | ||
|
||
// confirm our navStart's correctly match | ||
const navStartTs = metrics.find(e => e.id === 'navstart').ts; | ||
if (this.getNavigationStartEvt().ts !== navStartTs) { | ||
log.error('pwmetrics-events', 'Reference navigationStart doesn\'t match fMP\'s navStart'); | ||
return []; | ||
} | ||
|
||
metrics.forEach(metric => { | ||
if (metric.id === 'navstart') { | ||
return; | ||
} | ||
if (!metric.ts) { | ||
log.error('pwmetrics-events', `(${metric.name}) missing timestamp. Skipping…`); | ||
return; | ||
} | ||
log.verbose('pwmetrics-events', `Sythesizing trace events for ${metric.name}`); | ||
fakeEvents.push(...this.synthesizeEventPair(metric, navStartTs)); | ||
}); | ||
return fakeEvents; | ||
} | ||
} | ||
|
||
module.exports = Metrics; |
317 changes: 317 additions & 0 deletions
317
lighthouse-core/test/fixtures/dbw_tester-perf-results.json
Large diffs are not rendered by default.
Oops, something went wrong.
Oops, something went wrong.