Skip to content

Commit

Permalink
perf(config): disable styles gatherer (#2153)
Browse files Browse the repository at this point in the history
  • Loading branch information
patrickhulce authored and paulirish committed May 5, 2017
1 parent d2518c5 commit f7ea935
Show file tree
Hide file tree
Showing 3 changed files with 20 additions and 20 deletions.
8 changes: 4 additions & 4 deletions lighthouse-cli/test/fixtures/dobetterweb/dbw_tester.html
Original file line number Diff line number Diff line change
Expand Up @@ -309,7 +309,7 @@ <h2>Do better web tester page</h2>
notificationOnStartTest();
linksBlockingFirstPaintTest();
noRelOpenLinksTest();
oldCSSFlexboxTest();
// oldCSSFlexboxTest();
deprecationsTest();
} else {
if (params.has('documentWrite')) {
Expand Down Expand Up @@ -342,9 +342,9 @@ <h2>Do better web tester page</h2>
if (params.has('relnoopener')) {
noRelOpenLinksTest();
}
if (params.has('oldcssflexbox')) {
oldCSSFlexboxTest();
}
// if (params.has('oldcssflexbox')) {
// oldCSSFlexboxTest();
// }
if (params.has('deprecations')) {
deprecationsTest();
}
Expand Down
26 changes: 13 additions & 13 deletions lighthouse-cli/test/smokehouse/dobetterweb/dbw-expectations.js
Original file line number Diff line number Diff line change
Expand Up @@ -102,16 +102,16 @@ module.exports = [
}
}
},
'no-old-flexbox': {
score: false,
extendedInfo: {
value: {
results: {
length: 7
}
}
}
},
// 'no-old-flexbox': {
// score: false,
// extendedInfo: {
// value: {
// results: {
// length: 7
// }
// }
// }
// },
'no-websql': {
score: false,
debugString: 'Found database "mydb", version: 1.0.'
Expand Down Expand Up @@ -244,9 +244,9 @@ module.exports = [
'no-mutation-events': {
score: true
},
'no-old-flexbox': {
score: true
},
// 'no-old-flexbox': {
// score: true
// },
'no-websql': {
score: true
},
Expand Down
6 changes: 3 additions & 3 deletions lighthouse-core/config/default.js
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ module.exports = {
"useThrottling": false,
"gatherers": [
"chrome-console-messages",
"styles",
// "styles",
// "css-usage",
"dobetterweb/all-event-listeners",
"dobetterweb/anchors-with-no-rel-noopener",
Expand Down Expand Up @@ -125,7 +125,7 @@ module.exports = {
"dobetterweb/no-datenow",
"dobetterweb/no-document-write",
"dobetterweb/no-mutation-events",
"dobetterweb/no-old-flexbox",
// "dobetterweb/no-old-flexbox",
"dobetterweb/no-websql",
"dobetterweb/notification-on-start",
"dobetterweb/script-blocking-first-paint",
Expand Down Expand Up @@ -710,7 +710,7 @@ module.exports = {
{"id": "no-websql", "weight": 1},
{"id": "is-on-https", "weight": 1},
{"id": "uses-http2", "weight": 1},
{"id": "no-old-flexbox", "weight": 1},
// {"id": "no-old-flexbox", "weight": 1},
{"id": "uses-passive-event-listeners", "weight": 1},
{"id": "no-mutation-events", "weight": 1},
{"id": "no-document-write", "weight": 1},
Expand Down

0 comments on commit f7ea935

Please sign in to comment.