more precise offline message

GoogleChrome · May 17, 2017 · fe1b87d · fe1b87d
1 parent 519da14
commit fe1b87d
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 8 deletions.
diff --git a/lighthouse-core/audits/works-offline.js b/lighthouse-core/audits/works-offline.js
@@ -41,15 +41,16 @@ class WorksOffline extends Audit {
    */
   static audit(artifacts) {
     let debugString;
-    if (artifacts.Offline !== 200 &&
-        !URL.equalWithExcludedFragments(artifacts.URL.initialUrl, artifacts.URL.finalUrl)) {
-      debugString = 'WARNING: You may be failing this check because your test URL ' +
-          `(${artifacts.URL.initialUrl}) was redirected to "${artifacts.URL.finalUrl}". ` +
-          'Try testing the second URL directly.';
+    const passed = artifacts.Offline === 200;
+    if (!URL.equalWithExcludedFragments(artifacts.URL.initialUrl, artifacts.URL.finalUrl)) {
+      const explanation = passed ? 'Your test URL' :
+          'You may be failing this check because your test URL';
+      debugString = `WARNING: ${explanation} (${artifacts.URL.initialUrl}) was redirected to ` +
+          `"${artifacts.URL.finalUrl}". Try testing the second URL directly to verify .`;
     }
 
     return {
-      rawValue: artifacts.Offline === 200,
+      rawValue: passed,
       debugString
     };
   }

diff --git a/lighthouse-core/test/audits/load-fast-enough-for-pwa-test.js b/lighthouse-core/test/audits/load-fast-enough-for-pwa-test.js
@@ -53,7 +53,7 @@ describe('PWA: load-fast-enough-for-pwa audit', () => {
     });
   });
 
-  it('fails a good TTI value with no throttling', () => {
+  it('warns on a good TTI value with no throttling', () => {
     // latencies are very short
     const mockNetworkRecords = [
       {_timing: {sendEnd: 0, receiveHeadersEnd: 50}, finished: true, _url: 'https://google.com/'},
@@ -62,7 +62,7 @@ describe('PWA: load-fast-enough-for-pwa audit', () => {
       {_timing: {sendEnd: 0, receiveHeadersEnd: 50}, finished: true, _url: 'https://google.com/b'},
     ];
     return FastPWAAudit.audit(generateArtifacts(5000, mockNetworkRecords)).then(result => {
-      assert.equal(result.rawValue, false);
+      assert.equal(result.rawValue, true);
       assert.ok(result.debugString.includes('network request latencies'));
       assert.ok(result.details, 'contains details when latencies were not realistic');
     });