Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Report: update scoring labels for "Performance Metrics" to be displayValues #1069

Closed
ebidel opened this issue Nov 28, 2016 · 0 comments
Closed

Report: update scoring labels for "Performance Metrics" to be displayValues #1069

ebidel opened this issue Nov 28, 2016 · 0 comments
Assignees
@ebidel
Labels
report

Comments

@ebidel
Copy link
Contributor

ebidel commented Nov 28, 2016

The scoring labels we have next to performance metrics make no sense and are confusing. Zero user timing marks created isn't a bad thing, but the color red indicates that it is.

These values should be displayValue instead of scores.

screen shot 2016-11-28 at 1 50 18 pm

screen shot 2016-11-28 at 1 50 14 pm
@ebidel ebidel added the report label Nov 28, 2016
@ebidel ebidel self-assigned this Nov 28, 2016
@ebidel ebidel changed the title Report: remove scoring labels for "Performance Metrics" Report: update scoring labels for "Performance Metrics" to be displayValues Nov 28, 2016
ebidel added a commit that referenced this issue Nov 28, 2016
@ebidel
Fixes #1069 - remove score labels for perf metrics section
812289c
@ebidel ebidel mentioned this issue Nov 28, 2016
Merged
@ebidel ebidel closed this as completed in 3448105 Nov 28, 2016
andrewrota pushed a commit to andrewrota/lighthouse that referenced this issue Jan 13, 2017
@ebidel @andrewrota
Fixes GoogleChrome#1069 - remove score labels for perf metrics section (
1de9888 
GoogleChrome#1072)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ebidel ebidel

Labels
report
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ebidel