Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TypeError: perf.getEntriesByName is not a function #12439

Closed
MarcLlobet opened this issue May 4, 2021 · 1 comment · Fixed by #12440
Closed

TypeError: perf.getEntriesByName is not a function #12439

MarcLlobet opened this issue May 4, 2021 · 1 comment · Fixed by #12440
Assignees

Comments

@MarcLlobet
Copy link

When updating node from 15 to 16 and running lighthouse I get this error:

TypeError: perf.getEntriesByName is not a function
    at Object.exports.stop (.../node_modules/marky/lib/marky.cjs.js:55:24)
    at Function.timeEnd (.../node_modules/lighthouse-logger/index.js:128:11)
    at Function.requireGatherers (.../node_modules/lighthouse/lighthouse-core/config/config.js:815:9)
    at new Config (.../node_modules/lighthouse/lighthouse-core/config/config.js:342:27)
    at generateConfig (.../node_modules/lighthouse/lighthouse-core/index.js:60:10)
    at lighthouse (.../node_modules/lighthouse/lighthouse-core/index.js:43:18)
    at runLighthouse (.../node_modules/lighthouse/lighthouse-cli/run.js:224:32)
    at processTicksAndRejections (node:internal/process/task_queues:96:5)
error Command failed with exit code 1.

Lighthouse-logger seems to use marky@1.2.0 which is using a deprecated performance method getEntriesByName.

@patrickhulce
Copy link
Collaborator

As noted in GoogleChrome/lighthouse-ci#596 (comment) @MarcLlobet this isn't a Lighthouse issue. The version marker is already flexible enough that it will install 1.2.2 if you aren't using a lockfile already (in which case its on the owner of the lockfile to update).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants