Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: update marky to latest #12440

Merged
merged 1 commit into from
May 4, 2021
Merged

deps: update marky to latest #12440

merged 1 commit into from
May 4, 2021

Conversation

brendankenny
Copy link
Member

fixes #12439 (but really just for contributors)

See nolanlawson/marky#18 for the issue in node 16 (introduced in nodejs/node#37970).

However as noted by @patrickhulce in GoogleChrome/lighthouse-ci#596 (comment), lighthouse-logger currently uses marky@^1.2.0, so any downstream project just needs to refresh their deps and they'll pick up 1.2.2.

However, contributors (with a git repo checkout) are subject to our yarn.lock files for dependencies, so we do need to update those for us.

@brendankenny brendankenny requested a review from a team as a code owner May 4, 2021 17:42
@brendankenny brendankenny requested review from adamraine and removed request for a team May 4, 2021 17:42
@google-cla google-cla bot added the cla: yes label May 4, 2021
@@ -2,16 +2,17 @@
# yarn lockfile v1


debug@^2.6.8:
debug@^2.6.9:
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

weird that the package.json version and actual version in here got bumped in #9398 but this line didn't 🤷

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TypeError: perf.getEntriesByName is not a function
3 participants