Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return total score in JSON and Pretty outputs #1285

Closed
sap1ens opened this issue Dec 23, 2016 · 2 comments
Closed

Return total score in JSON and Pretty outputs #1285

sap1ens opened this issue Dec 23, 2016 · 2 comments
Labels
good first issue report

Comments

@sap1ens
Copy link

sap1ens commented Dec 23, 2016

Right now you can get total lighthouse score only in one output type - HTML. JSON and Pretty output types don't show the total score.

This makes things more complicated when you want to integrate lighthouse with CI, because in this case you have to parse HTML...
maciej-ka added a commit to maciej-ka/lighthouse that referenced this issue Dec 29, 2016
@maciej-ka
Show total score in every output type
1ac80e2 
Adds a total score field to aggregate objects and presents that
information in every output type.
Closes: GoogleChrome#1285
@maciej-ka maciej-ka mentioned this issue Dec 29, 2016
Merged
@maciej-ka
Copy link
Contributor

Hi @sap1ens, pull request added. One clarification: currently there is no total score for a whole lighthouse report, it is separate for every aggregate with number scores. Only 'Progressive Web App' is such an aggregate right now, but in future there may be more.

@sap1ens
Copy link
Author

sap1ens commented Dec 29, 2016

Thanks!

andrewrota pushed a commit to andrewrota/lighthouse that referenced this issue Jan 13, 2017
@maciej-ka @andrewrota
Show total score in every output type
e9a6123 
Adds a total score field to aggregate objects and presents that
information in every output type.
Closes: GoogleChrome#1285
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue report
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@sap1ens @wardpeet @maciej-ka