Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WPT compat: support cache warm run #1664

Closed
patrickhulce opened this issue Feb 7, 2017 · 6 comments · Fixed by #1675
Closed

WPT compat: support cache warm run #1664

patrickhulce opened this issue Feb 7, 2017 · 6 comments · Fixed by #1675
Assignees
Labels
Milestone

Comments

@patrickhulce
Copy link
Collaborator

patrickhulce commented Feb 7, 2017

WPT performs a cache cold run and a cache warm run while LH always clears all storage for the origin and disables the network cache.

@patrickhulce patrickhulce added this to the Q1 2017 milestone Feb 7, 2017
@patrickhulce patrickhulce self-assigned this Feb 7, 2017
@ebidel ebidel added the WPT label Feb 7, 2017
@brendankenny
Copy link
Member

this implies a new pass with no perf-interfering gatherers?

@patrickhulce
Copy link
Collaborator Author

this implies a new pass with no perf-interfering gatherers?

I'd start with the ability to run from CLI with the storage clearing/cache disabling off.

@brendankenny
Copy link
Member

oh I see, not both cold and warm in one run 👍

@paulirish
Copy link
Member

I'd start with the ability to run from CLI with the storage clearing/cache disabling off.

Question.. should we have all these options available through the CLI or make a wpt-adapter.js in core that's a bit more custom

@patrickhulce
Copy link
Collaborator Author

I'm in favor of making most of these flags without coupling explicitly to WPT. I don't think it does anything too crazy aside from the video capture, and in some cases just brings nice functionality to all of Lighthouse.

@paulirish
Copy link
Member

k. i'm comfortable with both directions. just figured i'd ask. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants