Catch and dimiss javascript dialogs/alerts/prompts

[cedricbellet]

lighthouse http://jetcost.com

jetcost seems to call window.confirm during a lighthouse test, and so long as the window.confirm is open, lighthouse continues to wait. tested with 1.6.3

[ebidel]

Ugh. That's terrible.

Looks like this happens in mobile emulation. The double 'ugh' is tat the dialog translates to "Get the free Jetcost app for Android. The best deals for cheap flights in your pocket!"

Page.handleJavaScriptDialog might do the trick.

[paulirish]

Yeah good call @ebidel

Interestingly there is no chrome --flag for this, but we can do it with Page.handleJavaScriptDialog

We listen for the 'Page.javascriptDialogOpening' event to fire and whenever it does, we can immediately do sendCommand('Page.handleJavaScriptDialog', {accept: true}) and all is well. We might also want to supply a promptText property to the options in case the confirm prompt is asking for some text.

@cedricbellet do you want to give this a shot? It'd live completely in driver.js and just get setup once we're connected.

[ebidel]

Come to think of it, we might be able to also get a quick UX audit out of this for "Avoiding APIs that harm the user experience" :) No page in 2017 should be using dialogs/prompts like this.

[paulirish]

Very true!

[cedricbellet]

On honeymoon so have limited time but happy to take a look upon my return

…

On Mar 30, 2017 7:41 PM, "Paul Irish" ***@***.***> wrote: Very true! — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1939 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ACQZMdKI3VlRZoohMi0Mb1l3hMofVMcoks5rrD2ggaJpZM4Mu9tf> .