Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[meta] List of sites that give Lighthouse trouble #2293

Closed
33 of 47 tasks
patrickhulce opened this issue May 17, 2017 · 14 comments
Closed
33 of 47 tasks

[meta] List of sites that give Lighthouse trouble #2293

patrickhulce opened this issue May 17, 2017 · 14 comments

Comments

@patrickhulce
Copy link
Collaborator

patrickhulce commented May 17, 2017

To Investigate

Axe failures

Service worker/offline issues

Stopped tracing too early

Site misbehavior (aborted request, failed document, extremely slow server, etc)

Working but needed more than 30s

Working as of 2.6

Legend

💨 = can be flaky (received a bad trace or axe failure on at least one run, but not reproducible)
😢 = undesirable metric result (but correct according to definition)
🐌 = Lighthouse is slow, i.e. multiple seconds spent in gathering/auditing

@paulirish
Copy link
Member

paulirish commented May 17, 2017

perf diagnostics

@paulirish
Copy link
Member

paulirish commented May 17, 2017

classics

@brendankenny
Copy link
Member

brendankenny commented May 17, 2017

  • https://react-hn.appspot.com/ we stop too soon and only get TTCI ~50% of the time, TTFI ~80-90% of the time. Has an unusual SSR/delayed hydration load scheme that may be tricking us

@brendankenny
Copy link
Member

brendankenny commented May 17, 2017

  • https://www.vevo.com/ may fall into the same timing oddness category as react-hn where we're cutting off too early. In my latest plots/ run, it usually had end-of-trace at 20s, but neither TTCI or TTFI were found. There were four trace outliers, however, where it went for the full 30s timeout, and for those, TTFI was found in all four, TTCI was in three. (polish: listen for network idle after DCL #2271)

30s may be too short

all these struggled with TTI, but all also hit the 30s timeout

@patrickhulce
Copy link
Collaborator Author

30s may be too short

the new throttling is going to make this true for a lot of sites now, we will basically fail on all sites from deep's TTI variability study that had TTI of >25s, which is a lot

@patrickhulce
Copy link
Collaborator Author

re: https://airhorner.com I'm not seeing anything fishy, what fails usually?
re: https://react-hn.appspot.com/ to provide more color here, this app actually renders in response to websocket messages and fixing would require a CPU quietness signal over the protocol since we can't reasonably guess when to stop tracing with the current network request signals alone

@patrickhulce
Copy link
Collaborator Author

patrickhulce commented May 18, 2017

@benschwarz
Copy link
Contributor

@patrickhulce
Copy link
Collaborator Author

@benschwarz could you elaborate with what issues you're seeing there? On a couple runs the only issue I'm seeing is running up to the 30s timeout before TTCI is computed

@benschwarz
Copy link
Contributor

@benschwarz could you elaborate with what issues you're seeing there? On a couple runs the only issue I'm seeing is running up to the 30s timeout before TTCI is computed

Ok, if it runs at all it must've been fixed in the last two weeks. 👍
The 30s timeout is a whole other thing, which is being tracked elsewhere, right?

@ebidel
Copy link
Contributor

ebidel commented Jun 19, 2017

  • https://www.davidemaggio.it/ fails to finish.

  • large number of network requests: ~300

  • huge number of DOM nodes: 11,180 to be precise. Lighthouse spends a lot time in evaluating getEventListeners for ExternalAnchorsUseRelNoopenerAudit and other related audits.

@patrickhulce patrickhulce removed the P1 label Nov 7, 2017
@patrickhulce patrickhulce removed their assignment Nov 8, 2017
@patrickhulce patrickhulce removed this from the Sprint Tres: Oct 30 - Nov 12 milestone Nov 13, 2017
@upugo-dev
Copy link

@patrickhulce any update on these issues? we are experiencing TTI issues quite frequently during our testing

@patrickhulce
Copy link
Collaborator Author

@upugo-dev these were mostly addressed by 3.0 and is quite old, probably a candidate for closing. If you have a specific, reproducible error on a particular URL then file it in a separate issue 👍

@brendankenny
Copy link
Member

these were mostly addressed by 3.0 and is quite old, probably a candidate for closing

closing! We can have other issues for sites that give Lighthouse trouble without confusing things mixing in pre-3.0 issues :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants