-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
audit: Can prompt recurring visitor to install to homescreen #23
Comments
from the docs: "Your icon declarations should include a mime type of image/png" @brendankenny is going to verify in the source also found in <dimen name="webapp_home_screen_icon_size">48dp</dimen> |
currently required in manifest:
|
"valid". for url it's valid by chromium's gURL standards, right? and then the two names it checks for exists and not empty? |
for valid URL, it does appear that's correct. For the name checks, you may technically be able to get away with empty strings (it checks they aren't null), but I'm not sure. The manifest parse step may just covert empty strings to null. |
k cool |
Nearly done, but we need to check for 144px icons instead of 192px. (But having 192 icons would allow the test to pass) brendan said:
|
@brendan i have this alsmost complete in a branch on my fork. 1% battery. see you guys. |
To add to this, on a macbook pro, I get a "256px square icon is required" in Chrome. The 256px appears to come from it not taking the emulated screen into account, but we may need to investigate the "square" part of that. This seems to discard non-square icons: but this explicitly tests non-square as OK: so not sure how these two worlds interact within Chrome. |
Fixed by the icons PR: #116 |
Just verifying the check here: validity requires ALL of these:
Our audit is a little softer in its tests so far. It doesn't look at standalone/fullscreen and doesn't consider SW controlling the starturl. Also it checks for |
this one has been confusing because of the difference in context of use of the
IMO we should get rid of the manifest |
Looked again at the current implementation (installable_manager.cc and app_banner_manager.cc):
|
Manual evaluation: manifest has short_name, 144x144 png icon
input:
audit:
image/png
or filename ending in.png
)update: ^ Copied from brendan's comment below.
See also "PWA validator" bookmarklet - #17
docs: install-to-homescreen on /web
when:
The text was updated successfully, but these errors were encountered: