Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix launcher w/ arbitrary flags #2670

Merged
merged 1 commit into from
Jul 11, 2017
Merged

fix launcher w/ arbitrary flags #2670

merged 1 commit into from
Jul 11, 2017

Conversation

paulirish
Copy link
Member 

❯ chrome-debug --hide-scrollbars
/Users/paulirish/code/lighthouse/chrome-launcher/manual-chrome-launcher.js:25
  port = chromeFlags.find(flag => flag.startsWith('--port=')).replace('--port=', '');
                                                             ^

TypeError: Cannot read property 'replace' of undefined

i introduced this bug in #2644. whoops.

@paulirish paulirish merged commit 8c9724e into master Jul 11, 2017
@paulirish paulirish deleted the manuallaun branch July 11, 2017 01:18
paulirish added a commit to GoogleChrome/chrome-launcher that referenced this pull request Aug 29, 2017
@paulirish
fix launcher w/ arbitrary flags (GoogleChrome/lighthouse#2670)
1b530f2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patrickhulce patrickhulce patrickhulce approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@paulirish @patrickhulce