Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compile-devtools is failing #4735

Closed
paulirish opened this issue Mar 12, 2018 · 1 comment · Fixed by #4737
Closed

compile-devtools is failing #4735

paulirish opened this issue Mar 12, 2018 · 1 comment · Fixed by #4737

Comments

@paulirish
Copy link
Member

paulirish commented Mar 12, 2018

The yarn compile-devtools script has been failing for the past few days.

Here's two recent builds from master:

PASSING: https://travis-ci.org/GoogleChrome/lighthouse/jobs/351077847#L828
FAILING: https://travis-ci.org/GoogleChrome/lighthouse/jobs/351130910#L826

Both appear to check out the exact same hash of -frontend and -protocol. Which indicates it's only Lighthouse that's changing.

Here's the error:

devtools frontend compilation output:
/tmp/tmp6f4UuQ/front_end/bindings/FileUtils.js:146: WARNING - Property result never defined on EventTarget
    const buffer = event.target.result;
                                ^^^^^^

I'm not really sure why this started cropping up after bc9efba, but a bisect confirmed that this is the commit where it started.

@paulirish
Copy link
Member Author

paulirish commented Mar 12, 2018

This event.target.result is coming from filereader's onload event.

I don't see any recent changes to Event, EventTarget happening in our externs, devtools externs, or the closure ones (and here).

and running yarn run closure against latest devtools frontend reports no errors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant