Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report: make sure warnings within Passed Audits are visible #5327

Closed
paulirish opened this issue May 23, 2018 · 1 comment · Fixed by #6989
Closed

Report: make sure warnings within Passed Audits are visible #5327

paulirish opened this issue May 23, 2018 · 1 comment · Fixed by #6989

Comments

@paulirish
Copy link
Member

Breaking this out of the discussion here:
#5270 (comment)

Current plan is to do a little block of warnings following the "Passed Audits" section:

inlinewarning-for-passed-audits-ideas

I'll likely be landing this after the toplevel->auditlevel & visual changes in #5270

cc @hwikyounglee

@paulirish paulirish changed the title Report: make sure passed audit warnings are visible Report: make sure warnings within Passed Audits are visible May 23, 2018
@brendankenny
Copy link
Member

Also need to update and enable the test skipped here:

it.skip('renders the failed audits grouped by group', () => {
(or replace it with a new one or whatever...either way the skipped one just needs to go :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment