Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Does not provide fallback content when JavaScript is not available #5563

Closed
ghost opened this issue Jun 26, 2018 · 4 comments · Fixed by #5571
Closed

[BUG] Does not provide fallback content when JavaScript is not available #5563

ghost opened this issue Jun 26, 2018 · 4 comments · Fixed by #5571
Labels

Comments

@ghost
Copy link

ghost commented Jun 26, 2018

Bug report

Provide the steps to reproduce

  1. Run LH on

What is the current behavior?

If I use this code (example code):

<noscript>
	<iframe src="noscript.html" frameborder="0" style="height: 100%; width: 100%;"></iframe>
	<noframes>You maybe have disabled JavaScript and Frames, please enable JavaScript or frames in You browser. More info: <br>
		<a href="http://tutorial.com/how-to-enable-js">How to enable JavaScript</a> <br>
		<a href="http://tutorial.com/how-to-enable-frames">How to enable frames</a>
	</noframes>
</noscript>

screenshot_192

What is the expected behavior?

do not report warning

Environment Information

V8 6.7.288.46
Related issues

@patrickhulce
Copy link
Collaborator

I suppose it's arguable if an iframe is sufficient content when script is not enabled. Traversing the entire frame tree to find text is a lot of complexity to add for a minimally useful audit.

Aside: curious why not just redirect to the noscript page if the iframe is the only intended content?

@ghost
Copy link
Author

ghost commented Jun 26, 2018

that code was only for example,... but I think, it does not report warning when someone use code similiar to that in example. Maybe lighthouse need only look if noscript tag is in webpage, and if it isn't empty.

@sekisanchi
Copy link

Phishtank needs this improvement, I guess.

@patrickhulce
Copy link
Collaborator

Maybe lighthouse need only look if noscript tag is in webpage, and if it isn't empty.

That's a good idea 👍 the only point of the audit is to force the developer to consider the noscript case :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants