Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Left align for numeric columns? #6084

Closed
exterkamp opened this issue Sep 20, 2018 · 1 comment
Closed

Left align for numeric columns? #6084

exterkamp opened this issue Sep 20, 2018 · 1 comment
Assignees
@connorjclark
Labels
bug chillin ❄

Comments

@exterkamp
Copy link
Member

Provide the steps to reproduce

When getting the DOM size table, the Value column is text and is therefore left aligned, should it be right aligned?
add_numeric

I suggest adding a lh-table-column--numeric type for things that are just numbers with no type that need to be left aligned?
@wardpeet
Copy link
Collaborator

It should be right indeed.

@connorjclark connorjclark self-assigned this Oct 23, 2018
connorjclark added a commit that referenced this issue Oct 23, 2018
@connorjclark
core(report): right-align DOM size table values (#6084)
a646411
@connorjclark connorjclark mentioned this issue Oct 23, 2018
Merged
connorjclark added a commit that referenced this issue Oct 24, 2018
@connorjclark
core(report): right-align DOM size table values (#6084)
3ecc2fe
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@connorjclark connorjclark

Labels
bug chillin ❄
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@wardpeet @connorjclark @exterkamp