Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adopt firstMeaningfulPaint trace event #618

Closed
paulirish opened this issue Aug 29, 2016 · 3 comments · Fixed by #1066
Closed

Adopt firstMeaningfulPaint trace event #618

paulirish opened this issue Aug 29, 2016 · 3 comments · Fixed by #1066
Assignees

Comments

@paulirish
Copy link
Member

paulirish commented Aug 29, 2016

  • category: blink.user_timing
  • name: firstMeaningfulPaint

According to new data (https://docs.google.com/document/d/16ItLkzm0IX2RKoAlztqrAmv30L9mJcDeYLJuGsH6QUo/edit#), the trace event implementation has better accuracy than the trace-based one. (both the LH impl and the catapult one)

This event is in m54, so we'll have some time before that's in stable. I propose we use our calculation as fallback until then.

Once we're ready to remove we can nuke the disabled-by-default-blink.debug.layout category as well.

@irori
Copy link

irori commented Sep 8, 2016

Note that blink.user_timing:firstMeaningfulPaint is not logged until network activity of the page is stabilized (currently 2 secs of no network activity, but it's subject to change).

Instead, catapult uses loading:firstMeaningfulPaintCandidate trace event which is logged every time layout significance marks a record. The timestamp of the last candidate is the time of first-meaningful-paint.

@paulirish
Copy link
Member Author

Super useful, thanks.

The 2sec-of-no-network-activity heuristic is probably something we should match in #627 as well.

@wardpeet
Copy link
Collaborator

@brendankenny @paulirish Mind if I take this one? (remove me if you rather want to do it)

paulirish pushed a commit that referenced this issue Dec 2, 2016
* Use fMP from chrome timings instead of calculating it ourselves.
* Cleanup audit & driver
* Cleanup unused functions
* Fix fmp calculations
* Fix test records

fixes #618, #1010, #890 and a part of #753
pr: #1066
andrewrota pushed a commit to andrewrota/lighthouse that referenced this issue Jan 13, 2017
* Use fMP from chrome timings instead of calculating it ourselves.
* Cleanup audit & driver
* Cleanup unused functions
* Fix fmp calculations
* Fix test records

fixes GoogleChrome#618, GoogleChrome#1010, GoogleChrome#890 and a part of GoogleChrome#753
pr: GoogleChrome#1066
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants