-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adopt firstMeaningfulPaint trace event #618
Comments
Note that blink.user_timing:firstMeaningfulPaint is not logged until network activity of the page is stabilized (currently 2 secs of no network activity, but it's subject to change). Instead, catapult uses loading:firstMeaningfulPaintCandidate trace event which is logged every time layout significance marks a record. The timestamp of the last candidate is the time of first-meaningful-paint. |
Super useful, thanks. The 2sec-of-no-network-activity heuristic is probably something we should match in #627 as well. |
@brendankenny @paulirish Mind if I take this one? (remove me if you rather want to do it) |
* Use fMP from chrome timings instead of calculating it ourselves. * Cleanup audit & driver * Cleanup unused functions * Fix fmp calculations * Fix test records fixes GoogleChrome#618, GoogleChrome#1010, GoogleChrome#890 and a part of GoogleChrome#753 pr: GoogleChrome#1066
blink.user_timing
firstMeaningfulPaint
According to new data (https://docs.google.com/document/d/16ItLkzm0IX2RKoAlztqrAmv30L9mJcDeYLJuGsH6QUo/edit#), the trace event implementation has better accuracy than the trace-based one. (both the LH impl and the catapult one)
This event is in m54, so we'll have some time before that's in stable. I propose we use our calculation as fallback until then.
Once we're ready to remove we can nuke the
disabled-by-default-blink.debug.layout
category as well.The text was updated successfully, but these errors were encountered: