Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Audit.Result.displayValue should always be a string #6200

Closed
exterkamp opened this issue Oct 9, 2018 · 0 comments · Fixed by #6767
Closed

Audit.Result.displayValue should always be a string #6200

exterkamp opened this issue Oct 9, 2018 · 0 comments · Fixed by #6767
Assignees
@exterkamp
Labels
i18n internationalization thangs needs-priority

Comments

@exterkamp
Copy link
Member

Provide the steps to reproduce

displayValue is sometimes a string when it has been translated (like in the perf category) but it is sometimes still in its untranslated form of an array of elements. e.g.

displayValue: [
    "%dms of time",
    100
]
@exterkamp exterkamp self-assigned this Oct 9, 2018
@exterkamp exterkamp mentioned this issue Oct 9, 2018
Merged
10 tasks
@brendankenny brendankenny changed the title DisplayValue mixed content Audit.Result.displayValue should always be a string Oct 10, 2018
@paulirish paulirish mentioned this issue Oct 15, 2018
Closed
10 tasks
@brendankenny brendankenny mentioned this issue Oct 22, 2018
Closed
This was referenced Dec 10, 2018
Merged
Closed
@exterkamp exterkamp added i18n internationalization thangs P1 and removed P1 labels Dec 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@exterkamp exterkamp

Labels
i18n internationalization thangs needs-priority
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

core(displayvalue): change displayValue to be string only GoogleChrome/lighthouse
2 participants
@paulirish @exterkamp