Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add timeout to all protocol commands #6296

Closed
connorjclark opened this issue Oct 16, 2018 · 1 comment
Closed

Add timeout to all protocol commands #6296

connorjclark opened this issue Oct 16, 2018 · 1 comment
Assignees

Comments

@connorjclark
Copy link
Collaborator

Some commands already do this (see getRequestContent and _evaluateInContext in the driver). We could benefit from implementing a timeout for all commands.

where: sendCommand in lighthouse-core/gather/connections/connection.js

Would prevent issues like #6287

@connorjclark
Copy link
Collaborator Author

for later

// Protocol timeout failures
  PROTOCOL_TIMEOUT: {
    code: 'PROTOCOL_TIMEOUT',
    message: strings.protocolTimeout,
  },
-----
  protocolTimeout: `Waiting for DevTools protocol response has exceeded the allotted time.`,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant