Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

configSettings.output can be list or string #6309

Closed
exterkamp opened this issue Oct 17, 2018 · 2 comments · Fixed by #6424
Closed

configSettings.output can be list or string #6309

exterkamp opened this issue Oct 17, 2018 · 2 comments · Fixed by #6424
Assignees

Comments

@exterkamp
Copy link
Member

exterkamp commented Oct 17, 2018

What is the current behavior?

LHR configSettings.output can be either a string or a list. For convergence with proto it needs to be one or the other.

@brendankenny
Copy link
Member

it's always an array from the CLI, so we'd just need to correct the module uses. It's marginally more annoying to use an array there, but not so bad.

It looks like all the client entry points all use the string version, and we'd need to update the default in constants.js.

@patrickhulce
Copy link
Collaborator

I'd also argue if we're converting it to always array that we should change the name to reports :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants