Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation on website doesn't seem to be udpated to v4 #7282

Closed
molant opened this issue Feb 20, 2019 · 7 comments
Closed

Documentation on website doesn't seem to be udpated to v4 #7282

molant opened this issue Feb 20, 2019 · 7 comments

Comments

@molant
Copy link

molant commented Feb 20, 2019

Lighthouse is currently on v4 but the documentation seemt to talk about v3 (Lighthouse v3 scoring guide). Also there are a few audits that have been disabled in the latest version but are still listed in the website. These are the ones I know of but there might be more:

https://developers.google.com/web/tools/lighthouse/audits/date-now
https://developers.google.com/web/tools/lighthouse/audits/console-time
https://developers.google.com/web/tools/lighthouse/audits/mutation-events
https://developers.google.com/web/tools/lighthouse/audits/old-flexbox

@antross
Copy link

antross commented Feb 20, 2019

Here are the PRs those were disabled/removed in:

I assume these were probably meant to be marked in the documentation as deprecated since that's what was done for the WebSQL audit documentation when it was removed.

@connorjclark
Copy link
Collaborator

@kaycebasques could we deprecate these?

@patrickhulce for #2153 it seems like you wanted to do some followup, but I didn't find any discussion on it after this PR. Think we could bring back the checks that this PR removed?

@patrickhulce
Copy link
Collaborator

patrickhulce commented May 20, 2019

@hoten are you referring to old flexbox? I'm not sure we want to bring that back 😆

For reference, #4183 was the conclusion/followup to #2153.

@connorjclark
Copy link
Collaborator

I meant the checks (against) using old flexbox

@patrickhulce
Copy link
Collaborator

Yeah I'm not sure that audit is really in line with the direction LH has taken over the past 2 years and certainly couldn't pass our new audit guidelines today. If you feel strongly about old flexbox though, by all means I would seriously love to read the questionnaire responses for someone making the case! :D

@connorjclark
Copy link
Collaborator

connorjclark commented May 20, 2019

~insert Futurama idc meme~

let's keep it dead then.

@brendankenny
Copy link
Member

brendankenny commented Jun 15, 2019

@mfriesenhahn is starting to take this over, starting with #9084

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants