pipe manifest fetch/parse error strings up for display

[brendankenny]

fixes #99

[brendankenny]

for example:

Lighthouse results: https://flipkart.com
Will Get Add to Homescreen Prompt: 17%
 -- Has a Service Worker registration: false
 -- Manifest exists: false
    Unable to fetch manifest at /manifest.json: 404: Not Found.
 -- Contains background_color: false
 -- Contains icons: false
 -- Contains 192px icons: false
 -- Contains short_name: false
 -- Site has a viewport meta tag: true

[paulirish]

what's this undefined arg?

[brendankenny]

it's the audit's rawValue, whatever that is. It could still be a boolean in this case, but then it'll be displayed twice with the current cli pretty printing.

The only place this is used currently is in the FMP output, which puts the actual time in parentheses. There's probably a better way of piping that through

[paulirish]

Yeah I like this setup, though I could prefer errorString as debugString.

[samccone]

looks like we still need to add tests around these error messages.

[brendankenny]

added a simple pass-through check. The more involved tests will be on the gatherer itself.

[brendankenny]

added debugString output to the extension as well. PTAL

[paulirish]

I was thinking that the property is always called debugString throughout the app, instead of using warning etc. Is that worth it?

[paulirish]

aside from this silly naming issue, lgtm, obviously.

[brendankenny]

whoops, didn't notice your last comment. Don't feel strongly, so went with being consistent on using debugString.

PTAL

[paulirish]

groovy. thanks amigo.

[samccone]

personally i really hate mixing the : syntax it is very confusing ... but maybe it is something to get used to for me.