Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: tweaks to auth + pptr docs #10277

Merged
merged 2 commits into from
Jan 30, 2020
Merged

docs: tweaks to auth + pptr docs #10277

merged 2 commits into from
Jan 30, 2020

Conversation

paulirish
Copy link
Member

@paulirish paulirish commented Jan 28, 2020

ref #6207 #9170

Copy link
Collaborator

@patrickhulce patrickhulce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM


--------------

**Note**: https://github.com/GoogleChrome/lighthouse/issues/3837 tracks the overall discussion for making Lighthouse work in concert with Puppeteer. Some things, like A/B testing the perf of UI changes, are tricky or not yet possible.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm so curious where the A/B testing the perf of UI changes comes from :)

I wouldn't really expect this to be related to puppeteer integration.

@patrickhulce patrickhulce merged commit 3e0e5f0 into master Jan 30, 2020
@patrickhulce patrickhulce deleted the paulirish-patch-1 branch January 30, 2020 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants