tests(smoke): deep clone expectations. do not use p.stdout #10361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
exterkamp
reviewed
Feb 21, 2020
|
@patrickhulce I choose you! |
| /** | ||
| * @param {Smokehouse.SmokehouseLibOptions} options | ||
| */ | ||
| async function smokehouse(options) { | ||
| const {urlFilterRegex, skip, modify, ...smokehouseOptions} = options; | ||
|
|
||
| /** @type {Smokehouse.TestDfn[]} */ | ||
| const clonedTests = JSON.parse(JSON.stringify(smokeTests)); | ||
| const clonedTests = deepCopy(smokeTests); |
There was a problem hiding this comment.
this is just dev dependency why not use just use _.cloneDeep? :) https://lodash.com/docs/4.17.15#cloneDeep
There was a problem hiding this comment.
if we decide to keep and maintain this ourselves instead I expect rigorous tests and edge cases ;)
connorjclark
changed the title
|
@paulirish what up with pr lint |
connorjclark
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found two issues when trying to consume this internally.