Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: evaluateAsync behavior #1037

Merged
merged 7 commits into from
Dec 3, 2016
Merged

fix: evaluateAsync behavior #1037

merged 7 commits into from
Dec 3, 2016

Commits on Nov 24, 2016

  1. fix: evaluateAsync behavior 

    addresses GoogleChrome#1000 and GoogleChrome#976

1. Ensures all `Runtime.evaluate` calls result in the native Promise
2. Transforms all errors produced during the evaluation to a standard object that can be rejected by our driver wrapper
    @patrickhulce
    patrickhulce committed Nov 24, 2016
    Configuration menu
    Copy the full SHA
    46b8301 View commit details
    Browse the repository at this point in the history

Commits on Nov 29, 2016

  1. fix: consistency with feedback on other PRs

    @patrickhulce
    patrickhulce committed Nov 29, 2016
    Configuration menu
    Copy the full SHA
    11ddfa7 View commit details
    Browse the repository at this point in the history

Commits on Nov 30, 2016

  1. more feedback

    @patrickhulce
    patrickhulce committed Nov 30, 2016
    Configuration menu
    Copy the full SHA
    ca5091d View commit details
    Browse the repository at this point in the history

Commits on Dec 2, 2016

  1. more more feedback

    @patrickhulce
    patrickhulce committed Dec 2, 2016
    Configuration menu
    Copy the full SHA
    c8e14c7 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'upstream/master' into fix_evaluate_async

    @patrickhulce
    patrickhulce committed Dec 2, 2016
    Configuration menu
    Copy the full SHA
    1343e61 View commit details
    Browse the repository at this point in the history

  3. Merge remote-tracking branch 'upstream/master' into fix_evaluate_async

    @patrickhulce
    patrickhulce committed Dec 2, 2016
    Configuration menu
    Copy the full SHA
    a97a2ea View commit details
    Browse the repository at this point in the history

  4. doh

    @patrickhulce
    patrickhulce committed Dec 2, 2016
    Configuration menu
    Copy the full SHA
    7c5995f View commit details
    Browse the repository at this point in the history