Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core(cls): add learn more link #10427

Merged
merged 2 commits into from Mar 10, 2020
Merged

core(cls): add learn more link #10427

merged 2 commits into from Mar 10, 2020

Conversation

connorjclark
Copy link
Collaborator

@kaycebasques for determining if we should have a page for CLS specific to LH, https://web.dev/lighthouse-cumulative-layout-shift/ ?

@kaycebasques
Copy link
Contributor

kaycebasques commented Mar 7, 2020

Yes, we should. Linking to web.dev/cls is good enough for now IMO. See GoogleChrome/web.dev#2316 to track progress of the Lighthouse-specific guide.

@connorjclark
Copy link
Collaborator Author

Cool. I'll let this linger unmerged for now but if we must we'll merge this for 6.0 and update later.

@connorjclark
Copy link
Collaborator Author

connorjclark commented Mar 7, 2020

Oh, we're hiding this by default for 6.0 so this is super puntable @kaycebasques

Copy link
Member

@paulirish paulirish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's do it.

lighthouse-core/audits/metrics/cumulative-layout-shift.js Outdated Show resolved Hide resolved
lighthouse-core/lib/i18n/locales/en-US.json Outdated Show resolved Hide resolved
lighthouse-core/lib/i18n/locales/en-XL.json Outdated Show resolved Hide resolved
lighthouse-core/test/results/sample_v2.json Outdated Show resolved Hide resolved
proto/sample_v2_round_trip.json Outdated Show resolved Hide resolved
Co-Authored-By: Paul Irish <paulirish@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants