misc: ignore duplicate builds in lhci dogfood #10482
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulirish
approved these changes
Mar 19, 2020
| lhci upload \ | ||
| --serverBaseUrl="$LHCI_CANARY_SERVER_URL" \ | ||
| --token="$LHCI_CANARY_SERVER_TOKEN" \ | ||
| --github-token="$BUNDLESIZE_GITHUB_TOKEN" \ |
There was a problem hiding this comment.
hah just noticed this. funny that we just reuse.
admittedly all the GH tokens necessary within CI makes a mess so i'm not entirely surprised. :)
|
oops didnt mean to steal from @brendankenny |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
master can't pass right now because of the lhci duplicate build problem, so thought I'd update us to use the new
--ignoreDuplicateBuildFailureflag