tests(smokehouse): loosen wastedMs for unused-javascript #10561
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brendankenny
requested review from
brendankenny
and removed request for
exterkamp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
the extra comments added to the smoketest by #10506 increased the document size which reduces the savings estimate
just adding those comments pushes the document size over another round trip to change the savings from 450 to 300 🙂
i.e. the document itself takes another round trip now so the JS finishing at 2.5s instead of 2.95s doesn't save .45s anymore, it saves 2.95s - max(2.5s, document finish time)
Related Issues/PRs
recent travis build failures introduced by #10506 (but only sometimes?)
I can't reliably reproduce the devtools node path failure locally anymore, so I'm not sure what's up with that