fix: remove paintNonDefaultBackgroundColor from user timings
#1077
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't show paintNonDefaultBackgroundColor with user timings Fixes GoogleChrome#934
|
It might be nice keep browser-created marks. Is there a way we can differentiate/style them differently than user-created ones? I think Chrome is working on adding a few more of these metrics and it would be useful for LH to preserve showing them. |
|
sure but shouldn't we break them out of user-timings regardless? smells like a new audit to me |
|
It might depend on what the plan is for these new metrics. If they're marks
that will eventually surface in the timeline, we may want to keep them. If
they will always be an internal thing, then we should probably ditch them.
CC @paulirish
…On Tue, Nov 29, 2016, 9:11 AM Patrick Hulce ***@***.***> wrote:
sure but shouldn't we break them out of user-timings regardless? smells
like a new audit to me
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#1077 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAOigPJQEyFhGvfkFHi4IiiYsub2a6QAks5rDFzRgaJpZM4K_OL_>
.
|
brendankenny
changed the title
paintNonDefaultBackgroundColor from user timings
|
ya agree it shouldn't be in our report for user timings. surfacing them elsewhere seems good but i'd rather be deliberate about that. |
paulirish
approved these changes
Nov 30, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't show paintNonDefaultBackgroundColor with user timings
Fixes #934