misc(benchmark): update BenchmarkIndex for m86 changes #11304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrickhulce
requested review from
connorjclark
and removed request for
a team
patrickhulce
commented
Aug 24, 2020
| * The division by 10 is to keep similar magnitudes to an earlier version of BenchmarkIndex that | ||
| * used a string length of 100000 instead of 10000. | ||
| */ | ||
| function benchmarkIndexGC() { |
There was a problem hiding this comment.
this is identical to the original other than the string is 10x smaller
| @@ -160,13 +160,13 @@ class Driver { | |||
| } | |||
|
|
|||
| /** | |||
| * Computes the ULTRADUMB™ benchmark index to get a rough estimate of device class. | |||
There was a problem hiding this comment.
awwww it's learning :)
There was a problem hiding this comment.
heh, yeah I figured now that there was a smidge of thought put into it and actual guidance from js-engine folks it needed a slight upgrade :)
connorjclark
approved these changes
Aug 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
tl;dr - Updates the BenchmarkIndex using advice from v8 team and research in #9085.
See #9085 for the very long, full story. We unfortunately missed the boat for m86 DevTools but at least would be nice to get it in for the CLI and LightRider.
Related Issues/PRs
ref #9085