Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

report: add score shapes to legend #11440

Merged
merged 1 commit into from Sep 17, 2020
Merged

report: add score shapes to legend #11440

merged 1 commit into from Sep 17, 2020

Conversation

adrianaixba
Copy link
Collaborator

@adrianaixba adrianaixba commented Sep 16, 2020 •
edited

fixes #11005

Adding shapes to legend to improve usability

Before:
Screen Shot 2020-09-16 at 4 55 26 PM

After:
Screen Shot 2020-09-16 at 4 54 57 PM

@adrianaixba adrianaixba requested a review from a team as a code owner September 16, 2020 21:09
@adrianaixba adrianaixba requested review from adamraine and removed request for a team September 16, 2020 21:09
@connorjclark connorjclark changed the title report: adding score shapes on legend report: add score shapes to legend Sep 16, 2020
adamraine
adamraine approved these changes Sep 16, 2020
View reviewed changes
Copy link
Member

@adamraine adamraine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@brendankenny
Copy link
Member

nice!

@adrianaixba adrianaixba merged commit b080896 into master Sep 17, 2020
@adrianaixba adrianaixba deleted the score-shapes branch September 17, 2020 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamraine adamraine adamraine approved these changes

Assignees

@adamraine adamraine

Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve Colorblind Score Shapes Usability
5 participants
@adrianaixba @brendankenny @adamraine @googlebot @devtools-bot