misc(build): give build-tracker a shared git history on PRs #11449
Conversation
paulirish
changed the title
| # buildtracker runs `git merge-base HEAD origin/master` which needs more history than depth=1. https://github.com/paularmstrong/build-tracker/issues/106 | ||
| - name: Deepen git fetch (for buildtracker) | ||
| run: git fetch --deepen=100 | ||
| # buildtracker needs history and a common merge commit. |
There was a problem hiding this comment.
Could we drop the entire script if we just skip this step if the current branch isn't master? so it only runs on commits merged to master.
There was a problem hiding this comment.
this script is mostly necessary for PRs.
though on master we need we need just 1 command... the git fetch --deepen.
the bash script early exists (line 26) in this case.
There was a problem hiding this comment.
Why do we want it tracking PR? It doesn't ever fail, right?
There was a problem hiding this comment.
we want master for timeseries historical data
we want prs for budgets. once bt is running successfully i can add bundle size budgets, which is the last remaining item to complete the move from the old bundlesize module to this.
buildtracker CLI won't have a non-zero exit code, even with failing budgets.. but i'll likely post to the status API to express the failure state
There was a problem hiding this comment.
Is there a way to check against a budget w/o uploading the data for the PR revision (and thus, no need to do this complex git stuff)?
There was a problem hiding this comment.
If build tracker UI can't filter to just master commits, I'm hesitant to mix the two data sources.
There was a problem hiding this comment.
If build tracker UI can't filter to just master commits, I'm hesitant to mix the two data sources.
totally. the UI filters to just master/default branch by default. so they're not mixed.
Is there a way to check against a budget w/o uploading the data for the PR revision (and thus, no need to do this complex git stuff)?
nope. while you can set 3 types of budgets (SIZE, DELTA, PERCENT_DELTA), the type we want is DELTA, which needs to know the baseline size, and only the server knows that. so in BT, the budgets are configured against the server instead of the client who's doing the build.
i asked the buildtracker maintainer about uploading non-master stuff and he said at twitter they upload all branches. BT may at some point allow switching the UI to look at a diff branch but its not implemented yet.
|
Can you add a link to the build tracker somewhere, maybe the readme? |
|
Is next action on reviewer here? |
| # Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License. | ||
| ## | ||
|
|
||
| set -euo pipefail |
build-tracker relies on a common commit that's shared between HEAD and master.
Lighthouse runs CI on pull_request, not push, so the checkout is not the branch with shared history, but the result of a merge.
The checkout@v2 action uses a merge remote (eg.
remotes/pull/9605/merge) that often has just a single commit. (single commit on these for our repo, not the case for other smaller repos... TBH i don't know how their logic works)This script creates a new branch that matches the current checkout, but does have a shared history.
ref #10472