Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(readme): tweak width and centering for some images #11504

Closed
wants to merge 3 commits into from

Conversation

codewithdev
Copy link

Summary

I have Aligned the images and videos in the readme file for the better preview.

Related Issues/PRs

@codewithdev codewithdev requested a review from a team as a code owner October 1, 2020 11:42
@codewithdev codewithdev requested review from Beytoven and removed request for a team October 1, 2020 11:42
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

Copy link
Collaborator

@patrickhulce patrickhulce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @codewithdev for opening a PR!

I'm not sure this is really better in most cases though.

Example: HTML Report is labelled by text that is immediately above it, but centering it on large screen sizes moves it quite far from its label

👍 (original)
image

👎 (this PR)
image

readme.md Outdated Show resolved Hide resolved
@codewithdev
Copy link
Author

Meaningful! I will add changes

@connorjclark connorjclark changed the title readme.md attacthed image alignment/ video alignment for the better view. docs(readme): tweak width and centering for some images Apr 26, 2022
@connorjclark
Copy link
Collaborator

Thanks @codewithdev! Can you sign the CLA?

@codewithdev
Copy link
Author

@connorjclark I've just done it. 🕺🏻

@connorjclark
Copy link
Collaborator

Sorry for delay. At the moment we cannot merge, but if you re-merge master back into your branch/fork we can.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants