Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: add devtools test for important data warning #11544

Merged
merged 2 commits into from
Oct 14, 2020
Merged

Conversation

adamraine
Copy link
Member

Imports devtools web test for the important data warning.

Devtools change: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2385182
Related #11438

@adamraine adamraine requested a review from a team as a code owner October 9, 2020 22:12
@adamraine adamraine requested review from connorjclark and removed request for a team October 9, 2020 22:13
@connorjclark connorjclark changed the title misc: add new web test for important data warning tests: add devtools test for important data warning Oct 9, 2020
@google-cla google-cla bot added the cla: yes label Oct 9, 2020
@adamraine
Copy link
Member Author

How do we update the DT version cached in Github?

@connorjclark
Copy link
Collaborator

in devtools.yml, change lighthouse/lighthouse-core/test/chromium-web-tests/download-* to lighthouse/lighthouse-core/test/chromium-web-tests/ (or maybe lighthouse/lighthouse-core/test/chromium-web-tests/* idk)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants