core(lantern): maximize throughput under HTTP/2 #11666
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Basically we were creating too many connections under HTTP/2 simulation in our connection pool that meant warm connections with excess bandwidth didn't get used properly.
It doesn't really have a huge effect in most real-world CLI or DevTools usage because we can usually trust the
connectionReused
boolean data from the network records there, but the effect in the tests @Beytoven was creating was large because most of our toy examples all share a connection ID (one of the conditions where we discard observed connection warmth).Related Issues/PRs
Fixes #11657