pull out CSS color validator and validate <meta> theme-color #117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -26,7 +27,10 @@ class ThemeColor extends Gather { | |||
| return driver.querySelector('head meta[name="theme-color"]') | |||
| .then(node => node && node.getAttribute('content')) | |||
| .then(themeColorMeta => { | |||
| return {themeColorMeta}; | |||
| if (themeColorMeta && validColor(themeColorMeta)) { | |||
There was a problem hiding this comment.
we should test this behavior :) (I know it is not complex, but think of the test as ensuring the contract is held up)
There was a problem hiding this comment.
so, setting up a test for this made it clear it was a bit weird to have in the gather phase. I've pushed it into the audit itself, and added tests for it there :)
|
moved the valid meta theme-color check into the audit, added Since the audits are type checked, also added externs for PTAL |
|
v nice. wfm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
also puts all of the current code to get
chrome-devtools-frontendable to be imported into lighthouse (the other place wasnetwork-recorder.js) into one file for easier maintenance.fixes #92