tests: rebaseline devtools test, print each .lh-audit id #11702
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
connorjclark
changed the title
patrickhulce
approved these changes
Nov 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes devtools webtests (currently breaking in master).
Not sure how this happened, but I suspect it was an issue with merging to master. I think when this https://github.com/GoogleChrome/lighthouse/pull/11409/files#diff-3989716969dfec47d8672087ea5e3d3005b9a70f41d7631a0406966c79057c95R569 merged it was a stale-ish branch, and since another PR had recently changed this number to
156there was no merge conflict.Anyway, I just rebaselined and changed the test to print every audit div id, so that a merge conflict like this can't happen again.