-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
core(image-elements): surface css properties in artifact #11707
Conversation
…itydescriptor prop, not needed.
types/artifacts.d.ts
Outdated
*/ | ||
usesSrcSetDensityDescriptor: boolean; | ||
/** `object-fit` CSS property. */ | ||
ObjectFit: string; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ObjectFit: string; | |
cssComputedObjectFit: string; |
WDYT to match the other cssComputed*
property convention?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like this! Makes a lot more sense and matches other properties 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
change itself looks good! 🎉
just a few leftover minor comments
sorry @adrianaixba you'll have some conflicts with #11695 landing now, looks great though! :) |
Surface css properties in ImageElements artifact. Move property validation logic to audits.
First item of #11642