core(stacks): actually support joomla and october cms #11788
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
connorjclark
requested review from
patrickhulce
and removed request for
a team
brendankenny
reviewed
Dec 8, 2020
| @@ -22,11 +22,7 @@ describe('stack-packs lib', () => { | |||
| const result = lighthouseStackPacksDep | |||
| .filter(p => !stackPacksLib.stackPacksToInclude.find(p2 => p2.packId === p.id)) | |||
| .map(p => p.id); | |||
| expect(result).toMatchInlineSnapshot(` | |||
| Array [ | |||
| "joomla", | |||
There was a problem hiding this comment.
ya it didnt work for its intended purpose lol
There was a problem hiding this comment.
well at least we know it works :)
There was a problem hiding this comment.
can we convert this to toEqual([]); with a comment that we shouldn't bother updating a stack pack until detectors are in place? :)
patrickhulce
approved these changes
Dec 8, 2020
| @@ -22,11 +22,7 @@ describe('stack-packs lib', () => { | |||
| const result = lighthouseStackPacksDep | |||
| .filter(p => !stackPacksLib.stackPacksToInclude.find(p2 => p2.packId === p.id)) | |||
| .map(p => p.id); | |||
| expect(result).toMatchInlineSnapshot(` | |||
| Array [ | |||
| "joomla", | |||
There was a problem hiding this comment.
can we convert this to toEqual([]); with a comment that we shouldn't bother updating a stack pack until detectors are in place? :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we needed these PRs GoogleChrome/lighthouse-stack-packs#59 GoogleChrome/lighthouse-stack-packs#60
and we needed to connect joomla detection to stack pack ...