tests(smoke): handle warn-not-offline-capable in smoketest #11799
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
connorjclark
reviewed
Dec 9, 2020
| errors: { | ||
| length: '>= 1', | ||
| 0: { | ||
| // In m89 the `warn-not-offline-capable` error was added. |
connorjclark
approved these changes
Dec 9, 2020
brendankenny
reviewed
Dec 9, 2020
| errors: [ | ||
| {errorId: 'no-icon-available'}, | ||
| ], | ||
| errors: { |
There was a problem hiding this comment.
I assume the audit(s) will have to account for this starting in #11745?
There was a problem hiding this comment.
yes indeed. i was thinking it'd be a followup PR. but yeah it'll have to be handled.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
another smoke failure with ToT chrome.. this time around the new
warn-not-offline-capable. There's an internal thread about this installability errorId. and here's the crbug: https://bugs.chromium.org/p/chromium/issues/detail?id=965802#c46smoke failure example from #11790:
This PR doesn't do much except allow this smoketest assertion to be a bit more lenient.
fwiw i could not reproduce receiving this errorId locally