Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core(config): special case full-page-screenshot audit in filtering #11829

Merged
merged 9 commits into from
Dec 16, 2020
Merged

core(config): special case full-page-screenshot audit in filtering #11829

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
80572c2
core(config): special case full-page-screenshot audit in filtering
connorjclark Dec 14, 2020
42565f5
tweak
connorjclark Dec 14, 2020
61a0135
comment
connorjclark Dec 14, 2020
8891a48
new shiz
connorjclark Dec 15, 2020
d2f4d65
tests
connorjclark Dec 16, 2020
68da84d
tests
connorjclark Dec 16, 2020
b71b3af
Merge remote-tracking branch 'origin/master' into config-fps
connorjclark Dec 16, 2020
e592f93
fix
connorjclark Dec 16, 2020
60f9d90
Update lighthouse-core/test/config/config-test.js
connorjclark Dec 16, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions lighthouse-core/config/config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -656,6 +656,19 @@ class Config {
}
});

// The `full-page-screenshot` audit belongs to no category, but we still want to include
// it for the categories that utilize it.
if (settings.onlyCategories) {
adamraine marked this conversation as resolved.
Show resolved Hide resolved
const includesCategoryUsingFullPageScreenshot = settings.onlyCategories.some(cat => {
return ['performance', 'accessibility'].includes(cat);
});
const explicitlyExcludesFullPageScreenshot =
settings.skipAudits && settings.skipAudits.includes('full-page-screenshot');
if (includesCategoryUsingFullPageScreenshot && !explicitlyExcludesFullPageScreenshot) {
includedAudits.add('full-page-screenshot');
}
}

return {categories, requestedAuditNames: includedAudits};
}

Expand Down
2 changes: 1 addition & 1 deletion ...omium-webtests/webtests/http/tests/devtools/lighthouse/lighthouse-export-run-expected.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,5 +8,5 @@ Tests that exporting works.

++++++++ testExportJson

# of audits (json): 152
# of audits (json): 153

5 changes: 5 additions & 0 deletions ...m-webtests/webtests/http/tests/devtools/lighthouse/lighthouse-successful-run-expected.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,7 @@ Gathering setup: Accessibility
Gathering setup: TraceElements
Gathering setup: InspectorIssues
Gathering setup: SourceMaps
Gathering setup: FullPageScreenshot
Beginning devtoolsLog and trace
Getting browser version
Loading page & waiting for onload
Expand Down Expand Up @@ -86,6 +87,7 @@ Gathering in-page: Accessibility
Gathering in-page: TraceElements
Gathering in-page: InspectorIssues
Gathering in-page: SourceMaps
Gathering in-page: FullPageScreenshot
Gathering trace
Gathering devtoolsLog & network records
Running afterPass methods
Expand Down Expand Up @@ -116,6 +118,7 @@ Gathering: Accessibility
Gathering: TraceElements
Gathering: InspectorIssues
Gathering: SourceMaps
Gathering: FullPageScreenshot
Populate base artifacts
Get webapp manifest
Collect stacks
Expand Down Expand Up @@ -247,6 +250,7 @@ Auditing: Page has valid source maps
Auditing: Preload Largest Contentful Paint image
Computing artifact: LanternLargestContentfulPaint
Computing artifact: LanternFirstContentfulPaint
Auditing: Full-page screenshot
Auditing: Site works cross-browser
Auditing: Page transitions don't feel like they block on the network
Auditing: Each page has a URL
Expand Down Expand Up @@ -455,6 +459,7 @@ font-display: pass
font-size: fail
form-field-multiple-labels: notApplicable
frame-title: notApplicable
full-page-screenshot: informative
geolocation-on-start: pass
gpt-bids-parallel: notApplicable
heading-order: notApplicable
Expand Down
1 change: 1 addition & 0 deletions ...m-webtests/webtests/http/tests/devtools/lighthouse/lighthouse-view-trace-run-expected.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ first-contentful-paint
first-cpu-idle
first-meaningful-paint
font-display
full-page-screenshot
interactive
largest-contentful-paint
largest-contentful-paint-element
Expand Down