Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core(config): only allow lighthouse:default extension #11835

Merged
merged 3 commits into from
Dec 15, 2020

Conversation

patrickhulce
Copy link
Collaborator

Summary
Closes the loop on a few consequences @paulirish and I discussed of #11779. Breaking change to eventually allow extension of lighthouse:mobile and lighthouse:desktop but make it clearer when your extends property is valid.

Before
Any truthy value for a config's extends property would trigger extension of the default config.

After
Any value other than lighthouse:default for a config's extends property throws a fatal error.

Related Issues/PRs
ref #11779
#10910 (comment)

@brendankenny
Copy link
Member

Oh good call on getting this in before 7. Drop the boolean from

extends?: 'lighthouse:default' | string | boolean;
too?

@adamraine
Copy link
Member

Can you also update:

### `extends: "lighthouse:default"|boolean|undefined`
The `extends` property controls if your configuration should inherit from the default Lighthouse configuration. [Learn more.](#config-extension)
Both the values `"lighthouse:default"` and `true` will enable inheritance, while `false` and `undefined` will not.

@patrickhulce
Copy link
Collaborator Author

Done and done, thanks @brendankenny @adamraine ! 👍

Copy link
Member

@adamraine adamraine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@patrickhulce patrickhulce merged commit ea5afa4 into master Dec 15, 2020
@patrickhulce patrickhulce deleted the only_allow_extends_default branch December 15, 2020 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants