misc(scripts): fix unbound variable in open-devtools #11845
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -43,4 +43,5 @@ cd "$DEVTOOLS_PATH" | |||
| gn gen out/Default | |||
| gclient sync | |||
| autoninja -C out/Default | |||
| "$CHROME_PATH" --custom-devtools-frontend=file://$DEVTOOLS_PATH/out/Default/resources/inspector | |||
|
|
|||
| "$CHROME_PATH" --custom-devtools-frontend=file://"$DEVTOOLS_PATH"/out/Default/resources/inspector --user-data-dir=/tmp/chromeprofile-open-devtools | |||
There was a problem hiding this comment.
can you remove that and just put $* here so you can call w/ whatever
connorjclark
approved these changes
Dec 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(low priority)
without the change on L17, the script errors our for me.
L25 is just making shellcheck happy
L47 i just wanted to reuse the same temporary chrome profile in these situations. @connorjclark @adamraine if the user-data-dir thang doesnt work for your workflows, no big deal. happy to add on my own. :)