core: handle timer throttling in DevTools to avoid timeouts #11987
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrickhulce
requested review from
connorjclark
and removed request for
a team
patrickhulce
commented
Jan 21, 2021
patrickhulce
commented
Jan 21, 2021
|
|
||
| // Chrome 88 introduced heavy throttling of timers which means our `setTimeout` will be executed | ||
| // at some point farish (several hundred ms) into the future and the time at which it executes isn't | ||
| // a reliable indicator of long task existence, instead we check if any information has changed. |
There was a problem hiding this comment.
to be fair to chrome, we were relying on something that was never promised, just because you ask for something to be done in 50ms doesn't mean it will happen within 100ms even if everything else is idle, it just happened to be true for the past two decades or so :)
connorjclark
approved these changes
Jan 21, 2021
patrickhulce
changed the title
paulirish
pushed a commit
that referenced
this pull request
Mar 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
tl;dr the newly enabled timer throttling messes with our CPU idle check
This should address our timeout issue in DevTools. I'm not sure how to test for this specific issue since I'm sure the reason it wasn't caught to begin with is that asserting certain tests don't timeout is a flaky chromium web test we wouldn't be able to land anyway 馃槵
Related Issues/PRs
fixes #11983