Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

misc: fix "fast" npm script #11997

Merged
merged 3 commits into from Jan 26, 2021
Merged

misc: fix "fast" npm script #11997

merged 3 commits into from Jan 26, 2021

Conversation

adamraine
Copy link
Member

Release test was failing on this step:

lighthouse/lighthouse-core/scripts/release/test.sh

Line 41 in 8533116

npm explore lighthouse -- npm run fast -- http://example.com

npm fast:

lighthouse/package.json

Line 59 in 8533116

"fast": "yarn start --emulated-form-factor=none --throttlingMethod=provided",

--emulated-form-factor is removed as of #11779

@adamraine adamraine requested a review from a team as a code owner January 25, 2021 23:59
@adamraine adamraine requested review from patrickhulce and removed request for a team January 25, 2021 23:59
@google-cla google-cla bot added the cla: yes label Jan 25, 2021
brendankenny
brendankenny reviewed Jan 26, 2021
View reviewed changes
package.json Outdated Show resolved Hide resolved
@adamraine @brendankenny
l
e9873ac 
Co-authored-by: Brendan Kenny <bckenny@gmail.com>
patrickhulce
patrickhulce approved these changes Jan 26, 2021
View reviewed changes
Copy link
Collaborator

@patrickhulce patrickhulce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IIRC the true purpose of this script was just to run Lighthouse as quickly as possible, so we could probably even get away with throttlingMethod only, but it's not a big deal :)

package.json Outdated Show resolved Hide resolved
@adamraine @patrickhulce
s
998f790 
Co-authored-by: Patrick Hulce <phulce@google.com>
@devtools-bot devtools-bot merged commit 01e8ebd into master Jan 26, 2021
@devtools-bot devtools-bot deleted the fix-release-test branch January 26, 2021 16:18
paulirish pushed a commit that referenced this pull request Mar 23, 2021
@adamraine @paulirish
misc: fix "fast" npm script (#11997)
231497a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brendankenny brendankenny brendankenny left review comments

@patrickhulce patrickhulce patrickhulce approved these changes

@connorjclark connorjclark connorjclark approved these changes

Assignees

@patrickhulce patrickhulce

Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@adamraine @brendankenny @patrickhulce @connorjclark @devtools-bot