Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use exec, not spawn, to kill Chrome process on Windows #1206

Merged
merged 1 commit into from
Dec 22, 2016
Merged

Use exec, not spawn, to kill Chrome process on Windows #1206

merged 1 commit into from
Dec 22, 2016

Conversation

XhmikosR
Copy link
Contributor

Using childProcess.spawnSync fails on Windows. childProcess.execSync works fine.

Fixes #1205.

Using `childProcess.spawnSync` fails on Windows. `childProcess.execSync` works fine.
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@XhmikosR
Copy link
Contributor Author

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

Copy link
Member

@brendankenny brendankenny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm curious about what's making the difference here, but haven't found much. Most advice out there is to exec taskkill anyways, so LGTM

@brendankenny brendankenny merged commit 1513a1d into GoogleChrome:master Dec 22, 2016
@brendankenny
Copy link
Member

Thanks for the fix!

@brendankenny brendankenny changed the title Update chrome-launcher.ts Use exec, not spawn, to kill Chrome process on Windows Dec 22, 2016
@XhmikosR XhmikosR deleted the patch-1 branch December 22, 2016 01:06
andrewrota pushed a commit to andrewrota/lighthouse that referenced this pull request Jan 13, 2017
…1206)

Using `childProcess.spawnSync` fails on Windows. `childProcess.execSync` works fine.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants